Merged
Conversation
Closed
- Auto-formatted .tf files with terraform fmt - Updated README.md with terraform-docs Co-authored-by: nourshoreibah <nourshoreibah@users.noreply.github.com>
Rayna-Yu
approved these changes
Feb 26, 2026
bhuvanh66
reviewed
Mar 25, 2026
| }), | ||
| ); | ||
|
|
||
| return `https://${bucketName}.s3.amazonaws.com/${key}`; |
Contributor
There was a problem hiding this comment.
could be wrong about this but you could use the s3 client config for this. does this default to us-east-2
|
|
||
| const s3 = new S3Client({ region: process.env.AWS_REGION ?? 'us-east-2' }); | ||
|
|
||
| function getBucketName(): string { |
Contributor
There was a problem hiding this comment.
could add validation for env vars to the handler instead of blank string
| projectId: number, | ||
| isAdmin: boolean, | ||
| ): Promise<boolean> { | ||
| if (isAdmin) return true; |
Contributor
There was a problem hiding this comment.
do you need to check if the project exists first?
bhuvanh66
approved these changes
Apr 2, 2026
Resolve merge conflicts to retain both POST /reports (PDF generation) and GET /reports (paginated list) endpoints, merging dependencies, tests, and OpenAPI specs from both branches. Made-with: Cursor
Pass URLResolver to PdfPrinter constructor (required since 0.3.7) and reorder handler to check project existence before access so non-existent projects return 404 instead of 403. Made-with: Cursor
nourshoreibah
force-pushed
the
add-report-generation
branch
from
c5f10a1 to
0869c66
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
…t/auth-forgot-reset-endpoints) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Terraform Plan 📖
|
Vaibhav978
approved these changes
Apr 12, 2026
| } | ||
|
|
||
| const { user } = authContext; | ||
| const body = event.body ? JSON.parse(event.body) as Record<string, unknown> : {}; |
Contributor
There was a problem hiding this comment.
Nitpick: we should add in a check in case the JSON is malformed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes #141
📝 Description
POST /reportsendpoint that generates a PDF report for a project , uploads to S3, and saves the recordmake uprun in foreground (blocking) instead of detachedAGENTS.mddocumenting the lambda CLI usageWrite a short summary of what you added. Why is it important? Any member of C4C should be able to read this and understand your contribution -- not just your team members.
Briefly list the changes made to the code:
✔️ Verification
make upfromapps/backend/POST /auth/signup, verify email viaPOST /auth/verify-emailPOST /auth/loginto get a JWTUPDATE branch.users SET is_admin = TRUE WHERE email = '...') or has a project membershiphttp://localhost:3005/reports/swagger, authorize with Bearer tokenPOST /reportswith{"project_id": 1}-> 201 withobject_urlobject_urlin browserGenerated this: https://c4c-branch-generated-reports20251030194253425700000001.s3.amazonaws.com/reports/1/2026-02-22T05-20-11-521Z.pdf
🏕️ (Optional) Future Work / Notes
Did you notice anything ugly during the course of this ticket? Any bugs, design challenges, or unexpected behavior? Write it down so we can clean it up in a future ticket!